Open jixiuf opened 2 years ago
Hi @jixiuf can I take this up please
@jixiuf This looks abandoned. Can I take this up? Please assign this to me. I will open a PR along with the relevant unit tests.
@evantorrie @jmacd @XSAM Can I take this up?
Feel free to open a PR and link this issue on it.
@pellared, @dmathieu, I can pick this up since it looks abandoned, but a few questions:
There is a plan to deprecate the module and move the ownership to MongoDB team.
I do not think it is worth to take the time in fix as there are no codeowners for this module so there is low chance that the PR will get a review.
Blocked by https://github.com/open-telemetry/opentelemetry-go-contrib/issues/4678 (no codeowners).
@pellared This issue can be closed as if https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6172 is accepted. semconv/v1.26.0 deprecates net.peer.ip
in favor of network.peer.address
.
https://github.com/open-telemetry/opentelemetry-go-contrib/blob/1e34aa359ff6cfe4ba2a44775d261311ea024197/instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/mongo.go#L54
should use
semconv.NetPeerIPKey
when hostname is a IP