search

open-telemetry / opentelemetry-go-contrib

Collection of extensions for OpenTelemetry-Go.
https://opentelemetry.io/
Apache License 2.0
1.2k stars 563 forks source link

jaeger.sampler.UpdateSampler() log output #2259

Open tttoad opened 2 years ago

tttoad commented 2 years ago

Background

The log output statement in the UpdateSampler function is commented out.

Proposed Solution

Maybe we can use the otel.Handle function to print the log

tttoad commented 2 years ago

image In code https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/samplers/jaegerremote/sampler_remote.go#L149 , the output of the log is commented out... The log should be output.