search

open-telemetry / opentelemetry-go-contrib

Collection of extensions for OpenTelemetry-Go.
https://opentelemetry.io/
Apache License 2.0
1.2k stars 563 forks source link

Deprecated linters need to be replaced #2896

Closed MrAlias closed 2 years ago

MrAlias commented 2 years ago

Upgrading golangci-lint (version 1.50.1) resulted in the following warnings:

level=warning msg="[runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused." level=warning msg="[runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused." level=warning msg="[runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."

Based on these messages we need to replace deadcode, structcheck, and varcheck with unused.

MrAlias commented 2 years ago

We already use unused so it looks to be a matter of just removing the deprecated linters.