search

open-telemetry / opentelemetry-go-contrib

Collection of extensions for OpenTelemetry-Go.
https://opentelemetry.io/
Apache License 2.0
1.17k stars 553 forks source link

autoexport: Rename `IsNone` to `IsNoneSpanExporter` #4133

Closed pellared closed 1 year ago

pellared commented 1 year ago

IsNone should to be renamed to IsNoneSpanExporter as there may be an equivalent reader/exporter for metrics in future.

_Originally posted by @pellared in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4132#discussion_r1281885990_

Note: Do not forget to also update the docs [IsNone] -> [IsNoneSpanExporter] as I am not sure if gorename handles it.

MrAlias commented 1 year ago

We should prioritize this to happen before the next release.

pellared commented 1 year ago

We should prioritize this to happen before the next release.

I plan to create a PR on Monday.