Make `otelhttp` produce old, new and duplicate Client Trace Attributes

open-telemetry / opentelemetry-go-contrib

Collection of extensions for OpenTelemetry-Go.

https://opentelemetry.io/

Apache License 2.0

1.16k stars 552 forks source link

Make `otelhttp` produce old, new and duplicate Client Trace Attributes #5332

Closed MadVikingGod closed 2 months ago

MadVikingGod commented 6 months ago

Make instrumentation/net/http/otelhttp produce Client Traces following the migration plan #5132.

A user should be able to produce Traces from the Transport in the current semconv (default), the latest semconv (1.26.0), and a duplicate form based on the Environment variable OTEL_HTTP_CLIENT_COMPATIBILITY_MODE

[x] Produce Old Client Attributes
~Produce Duplicate Client Attributes~
[x] Produce New Client Attributes
[x] Add a changelog entry

VinozzZ commented 2 months ago

I would like to work on the remaining task for this issue

VinozzZ commented 2 months ago

Implementation Plan:

Create a newHTTPClient that returns attributes from semconv v1.26.0
the newHTTPClient should implement RequestTraceAttrs, ResponseTraceAttrs, and Status methods
Add tests to check newHTTPClient is returning correct attributes
Add logic to check for environment variable OTEL_HTTP_CLIENT_COMPATIBILITY_MODE in HTTPClient to also return attributes from newHTTPClient if the env is set to http/dup. Otherwise, only return attributes from the oldHTTPClient

MrAlias commented 2 months ago

Done.