Open NeoCN opened 3 weeks ago
@dmathieu Currently no other info needed from the gin.Context
. Honestly, using gin.Context
will be more flexible as lots of things can be got from the context. Do we need the flexibility ?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 64.2%. Comparing base (
2dc32c1
) to head (26c54e1
).
Ping @hanyuancheung
@dmathieu @hanyuancheung Any suggestions for this PR?
For
Gin
framework, the route name can only be get by usingFullPath()
function ingin.Context
, the originalSpanNameFormatter
only has thehttp.Request
argument that can not get the right route name if route parameters used.This PR add
routeName
argument toSpanNameFormatter
function, align withSpanNameFormatter
inotelmux
.