Open dashpole opened 1 week ago
Attention: Patch coverage is 85.24590%
with 18 lines
in your changes missing coverage. Please review.
Project coverage is 64.9%. Comparing base (
522f603
) to head (ff06938
).
Waiting to merge so @XSAM can review.
Working on tests. metrics.Read is being strange during unit testing, and seems to always return the same result.
I had to add code that allocates memory to ensure the metric actually changes for the refresh test. I ran it locally with -count 10000
, and it passes, so hopefully it won't be flaky.
/gc/heap/allocs:bytes
and /gc/heap/allocs:objects
don't seem to be populated on windows. I'm investigating
I think I got the test passing
Part of https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5655
Changes:
options.go
without modification.Notes:
It doesn't implement
go.schedule.duration
, as the histogram will need some additional work to figure out.Based on https://github.com/prometheus/client_golang/pull/955#issue-1090830520, using go's runtime metrics should is more efficient than reading memstats.