open-telemetry / opentelemetry-go-contrib

Collection of extensions for OpenTelemetry-Go.
https://opentelemetry.io/
Apache License 2.0
1.07k stars 505 forks source link

Fix: Silently failing of sampling rules #5795

Closed ayushrakesh closed 5 days ago

ayushrakesh commented 6 days ago

Added status code in checking the getSamplingRules function. Added unit test for it.

Fixes #5717

Description

getSamplingRules method in the AWS X-Ray sampler did not check the HTTP response status code, potentially leading to incorrect handling of non-200 responses.

dmathieu commented 5 days ago

Duplicate of https://github.com/open-telemetry/opentelemetry-go-contrib/pull/5718