open-telemetry / opentelemetry-go-contrib

Collection of extensions for OpenTelemetry-Go.
https://opentelemetry.io/
Apache License 2.0
1.15k stars 544 forks source link

Add errorlint linter #5804

Closed dmathieu closed 3 months ago

dmathieu commented 3 months ago

This is the contrib counterpart of https://github.com/open-telemetry/opentelemetry-go/pull/5535, adding the errorlint linter.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes missing coverage. Please review.

Project coverage is 64.5%. Comparing base (ba4c2bb) to head (268aa72).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/pull/5804/graphs/tree.svg?width=650&height=150&src=pr&token=P6F3W9WA7Q&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/pull/5804?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #5804 +/- ## ===================================== Coverage 64.5% 64.5% ===================================== Files 200 200 Lines 12558 12560 +2 ===================================== + Hits 8103 8107 +4 + Misses 4218 4217 -1 + Partials 237 236 -1 ``` | [Files](https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/pull/5804?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [config/metric.go](https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/pull/5804?src=pr&el=tree&filepath=config%2Fmetric.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-Y29uZmlnL21ldHJpYy5nbw==) | `90.2% <100.0%> (+0.8%)` | :arrow_up: | | [detectors/aws/ec2/ec2.go](https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/pull/5804?src=pr&el=tree&filepath=detectors%2Faws%2Fec2%2Fec2.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-ZGV0ZWN0b3JzL2F3cy9lYzIvZWMyLmdv) | `90.0% <100.0%> (+0.1%)` | :arrow_up: | | [...ion/google.golang.org/grpc/otelgrpc/interceptor.go](https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/pull/5804?src=pr&el=tree&filepath=instrumentation%2Fgoogle.golang.org%2Fgrpc%2Fotelgrpc%2Finterceptor.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-aW5zdHJ1bWVudGF0aW9uL2dvb2dsZS5nb2xhbmcub3JnL2dycGMvb3RlbGdycGMvaW50ZXJjZXB0b3IuZ28=) | `89.4% <100.0%> (ø)` | | | [...tion/net/http/otelhttp/internal/semconv/v1.20.0.go](https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/pull/5804?src=pr&el=tree&filepath=instrumentation%2Fnet%2Fhttp%2Fotelhttp%2Finternal%2Fsemconv%2Fv1.20.0.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-aW5zdHJ1bWVudGF0aW9uL25ldC9odHRwL290ZWxodHRwL2ludGVybmFsL3NlbWNvbnYvdjEuMjAuMC5nbw==) | `100.0% <100.0%> (ø)` | | | [detectors/gcp/gce.go](https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/pull/5804?src=pr&el=tree&filepath=detectors%2Fgcp%2Fgce.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-ZGV0ZWN0b3JzL2djcC9nY2UuZ28=) | `11.3% <50.0%> (+2.0%)` | :arrow_up: | | [exporters/autoexport/metrics.go](https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/pull/5804?src=pr&el=tree&filepath=exporters%2Fautoexport%2Fmetrics.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-ZXhwb3J0ZXJzL2F1dG9leHBvcnQvbWV0cmljcy5nbw==) | `78.5% <0.0%> (ø)` | | | [...le.golang.org/grpc/otelgrpc/example/client/main.go](https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/pull/5804?src=pr&el=tree&filepath=instrumentation%2Fgoogle.golang.org%2Fgrpc%2Fotelgrpc%2Fexample%2Fclient%2Fmain.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-aW5zdHJ1bWVudGF0aW9uL2dvb2dsZS5nb2xhbmcub3JnL2dycGMvb3RlbGdycGMvZXhhbXBsZS9jbGllbnQvbWFpbi5nbw==) | `0.0% <0.0%> (ø)` | | | [...le.golang.org/grpc/otelgrpc/example/server/main.go](https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/pull/5804?src=pr&el=tree&filepath=instrumentation%2Fgoogle.golang.org%2Fgrpc%2Fotelgrpc%2Fexample%2Fserver%2Fmain.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-aW5zdHJ1bWVudGF0aW9uL2dvb2dsZS5nb2xhbmcub3JnL2dycGMvb3RlbGdycGMvZXhhbXBsZS9zZXJ2ZXIvbWFpbi5nbw==) | `0.0% <0.0%> (ø)` | | | [...lang.org/grpc/otelgrpc/internal/test/test\_utils.go](https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/pull/5804?src=pr&el=tree&filepath=instrumentation%2Fgoogle.golang.org%2Fgrpc%2Fotelgrpc%2Finternal%2Ftest%2Ftest_utils.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-aW5zdHJ1bWVudGF0aW9uL2dvb2dsZS5nb2xhbmcub3JnL2dycGMvb3RlbGdycGMvaW50ZXJuYWwvdGVzdC90ZXN0X3V0aWxzLmdv) | `50.0% <33.3%> (ø)` | |