open-telemetry / opentelemetry-go-contrib

Collection of extensions for OpenTelemetry-Go.
https://opentelemetry.io/
Apache License 2.0
1.22k stars 566 forks source link

add grpc support for log export #6340

Closed codeboten closed 1 week ago

codeboten commented 1 week ago

This adds support for grpc export for the logging signal in the config package.

~Leaving this in draft until https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6338 is merged and i'll rebase.~

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.9%. Comparing base (71759c6) to head (5adc7e4). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
config/log.go 96.8% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/pull/6340/graphs/tree.svg?width=650&height=150&src=pr&token=P6F3W9WA7Q&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/pull/6340?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #6340 +/- ## ===================================== Coverage 66.8% 66.9% ===================================== Files 193 193 Lines 15620 15652 +32 ===================================== + Hits 10448 10479 +31 - Misses 4881 4882 +1 Partials 291 291 ``` | [Files with missing lines](https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/pull/6340?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [config/log.go](https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/pull/6340?src=pr&el=tree&filepath=config%2Flog.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-Y29uZmlnL2xvZy5nbw==) | `94.9% <96.8%> (+0.5%)` | :arrow_up: |

🚨 Try these New Features:

MrAlias commented 1 week ago

@codeboten it looks like the white-space formatting needs to be updated to fix the lint.