search

open-telemetry / opentelemetry-go-instrumentation

OpenTelemetry Auto Instrumentation using eBPF
https://opentelemetry.io
Apache License 2.0
496 stars 77 forks source link

Review LogSize configuration #136

Open MikeGoldsmith opened 1 year ago

MikeGoldsmith commented 1 year ago

Review hardcoded logsize and whether we should allow users to adjust via configuration.

Originally posted by @MikeGoldsmith in https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/128#pullrequestreview-1409363569

edeNFed commented 1 year ago

Copying my comment from the original thread:

The default size is 1024 bytes, which may not be enough for all eBPF programs. This sets the size of the requested buffer allocated from the kernel when loading eBPF programs. Allowing users to control it may have some security concerns (for example, setting a really high value causing huge memory allocation)