open-telemetry / opentelemetry-go

OpenTelemetry Go API and SDK
https://opentelemetry.io/
Apache License 2.0
4.99k stars 1.01k forks source link

Add unconvert linter #5529

Closed dmathieu closed 1 week ago

dmathieu commented 1 week ago

This adds the unconvert linter, and fixes every new issue related to it.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.8%. Comparing base (4a509d2) to head (c9e4681).

:exclamation: Current head c9e4681 differs from pull request most recent head 487e72e

Please upload reports for the commit 487e72e to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5529/graphs/tree.svg?width=650&height=150&src=pr&token=8efTmh4kvf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5529?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #5529 +/- ## ======================================= - Coverage 84.8% 84.8% -0.1% ======================================= Files 269 269 Lines 18091 18091 ======================================= - Hits 15345 15344 -1 - Misses 2420 2421 +1 Partials 326 326 ``` | [Files](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5529?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [bridge/opencensus/internal/ocmetric/metric.go](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5529?src=pr&el=tree&filepath=bridge%2Fopencensus%2Finternal%2Focmetric%2Fmetric.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-YnJpZGdlL29wZW5jZW5zdXMvaW50ZXJuYWwvb2NtZXRyaWMvbWV0cmljLmdv) | `96.0% <100.0%> (ø)` | | | [...ic/otlpmetricgrpc/internal/transform/metricdata.go](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5529?src=pr&el=tree&filepath=exporters%2Fotlp%2Fotlpmetric%2Fotlpmetricgrpc%2Finternal%2Ftransform%2Fmetricdata.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-ZXhwb3J0ZXJzL290bHAvb3RscG1ldHJpYy9vdGxwbWV0cmljZ3JwYy9pbnRlcm5hbC90cmFuc2Zvcm0vbWV0cmljZGF0YS5nbw==) | `100.0% <100.0%> (ø)` | | | [...ic/otlpmetrichttp/internal/transform/metricdata.go](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5529?src=pr&el=tree&filepath=exporters%2Fotlp%2Fotlpmetric%2Fotlpmetrichttp%2Finternal%2Ftransform%2Fmetricdata.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-ZXhwb3J0ZXJzL290bHAvb3RscG1ldHJpYy9vdGxwbWV0cmljaHR0cC9pbnRlcm5hbC90cmFuc2Zvcm0vbWV0cmljZGF0YS5nbw==) | `100.0% <100.0%> (ø)` | | | [semconv/internal/v2/net.go](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5529?src=pr&el=tree&filepath=semconv%2Finternal%2Fv2%2Fnet.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c2VtY29udi9pbnRlcm5hbC92Mi9uZXQuZ28=) | `100.0% <100.0%> (ø)` | | | [semconv/internal/v3/net.go](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5529?src=pr&el=tree&filepath=semconv%2Finternal%2Fv3%2Fnet.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c2VtY29udi9pbnRlcm5hbC92My9uZXQuZ28=) | `100.0% <100.0%> (ø)` | | | [semconv/internal/v4/net.go](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5529?src=pr&el=tree&filepath=semconv%2Finternal%2Fv4%2Fnet.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c2VtY29udi9pbnRlcm5hbC92NC9uZXQuZ28=) | `100.0% <100.0%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5529/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)