open-telemetry / opentelemetry-go

OpenTelemetry Go API and SDK
https://opentelemetry.io/
Apache License 2.0
4.99k stars 1.01k forks source link

Parse errormsgs in retryable status codes #5541

Open pree-dew opened 1 week ago

pree-dew commented 1 week ago

@MrAlias PR #5537 had incorrect email address, that's why CLA was failing in order to fix it I have to change git history, which is not recommended in contribution guidelines so created this new PR and closing the old one.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.3%. Comparing base (f6a5aa2) to head (a2c49e6). Report is 21 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5541/graphs/tree.svg?width=650&height=150&src=pr&token=8efTmh4kvf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #5541 +/- ## ======================================= - Coverage 84.8% 84.3% -0.6% ======================================= Files 269 269 Lines 18089 22034 +3945 ======================================= + Hits 15345 18578 +3233 - Misses 2419 3128 +709 - Partials 325 328 +3 ``` [see 538 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5541/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)
pree-dew commented 5 days ago

@dmathieu Is there anything missing/incorrect in this PR that needs a fix? Happy to accomodate that.