search

open-telemetry / opentelemetry-go

OpenTelemetry Go API and SDK
https://opentelemetry.io/
Apache License 2.0
5.15k stars 1.04k forks source link

Move examples to contrib #5801

Open pellared opened 1 week ago

pellared commented 1 week ago

A follow-up after https://github.com/open-telemetry/opentelemetry-go/pull/5791 in contrib is required and afterwards here we need to fix the example/dice.

  1. [ ] Copy all example(s) to contrib
  2. [ ] Revert example/dice changes from https://github.com/open-telemetry/opentelemetry-go/pull/5791 so that it uses otelslog.
  3. [ ] Update the hyperlink to examples in core repo and otel.io to target contrib repo (instead of core)
  4. [ ] Deprecate the examples in core repo
  5. [ ] Remove the examples from core repo
MrAlias commented 6 days ago

This round-about dependency seems like something we should address. Should this example be moved to contrib? Should all examples?

pellared commented 6 days ago

This round-about dependency seems like something we should address. Should this example be moved to contrib?

It makes sense also because this example also uses go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp

Should all examples?

It may be indeed easier to keep all examples in contrib.

dashpole commented 5 days ago

I'm OK with moving examples to contrib