Closed krnowak closed 9 months ago
What about proto generation? How do you fix all the versions of protoc and plugins?
The current state of affairs is:
make precommit
- The only outstanding one is the thrift code in jaeger. I couldn't find the history of how we adopted this code.
IIRC, that was a manual copy paste.
AFAIK all code generation is now automated.
We have some generated files in the repo. Some of them are generated during
make precommit
(likeapi/core/numberkind_string.go
by the stringer utility). But some of them were generated just once and just lay there:protoc-gen-go
first myself.Would be nice to document it and add some
make
target (likemake generate-misc
) so it regenerates the files above. It's something maybe we could do as a part of a release process.