search

open-telemetry / opentelemetry-go

OpenTelemetry Go API and SDK
https://opentelemetry.io/docs/languages/go
Apache License 2.0
5.35k stars 1.09k forks source link

prometheus: Add instrumentation scope attributes to otel_scope_info #5932

Closed pellared closed 3 weeks ago

pellared commented 1 month ago

Towards https://github.com/open-telemetry/opentelemetry-go/issues/5846

Pre-work: https://github.com/open-telemetry/opentelemetry-go/pull/5806

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.6%. Comparing base (1230566) to head (9cee213). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5932/graphs/tree.svg?width=650&height=150&src=pr&token=8efTmh4kvf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5932?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #5932 +/- ## ===================================== Coverage 84.6% 84.6% ===================================== Files 272 272 Lines 22858 22864 +6 ===================================== + Hits 19341 19348 +7 + Misses 3173 3172 -1 Partials 344 344 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5932/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)
pellared commented 3 weeks ago

SIG meeting: Discussed with @dashpole. There would be a follow-up (seperate) PR to make scope attributes and scheme URL as identifying. See https://github.com/open-telemetry/opentelemetry-specification/issues/4223#issuecomment-2450771210. These changes are not conflicting.

pellared commented 3 weeks ago

@dashpole, merging to avoid conflicts when working on "make scope attributes and scheme URL as identifying". I can still address any comments that will be added later (post-merge).