search

open-telemetry / opentelemetry-go

OpenTelemetry Go API and SDK
https://opentelemetry.io/docs/languages/go
Apache License 2.0
5.34k stars 1.08k forks source link

Fix lint issues for golangci-lint 1.62.0 #5967

Closed dmathieu closed 1 week ago

dmathieu commented 2 weeks ago

This fixes the new lint issues brough by the golangci-lint upgrade in https://github.com/open-telemetry/opentelemetry-go/pull/5966

pellared commented 1 week ago

why are min and max not allowed as variable names?

To not shadow min and max added in Go 1.21

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.6%. Comparing base (0bf9572) to head (ce781a4). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5967/graphs/tree.svg?width=650&height=150&src=pr&token=8efTmh4kvf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5967?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #5967 +/- ## ======================================= - Coverage 84.6% 84.6% -0.1% ======================================= Files 272 272 Lines 22897 22897 ======================================= - Hits 19391 19390 -1 - Misses 3162 3163 +1 Partials 344 344 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5967/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)