search

open-telemetry / opentelemetry-go

OpenTelemetry Go API and SDK
https://opentelemetry.io/docs/languages/go
Apache License 2.0
5.34k stars 1.08k forks source link

[chore] Fix codecov action usage #5979

Closed pellared closed 1 week ago

pellared commented 1 week ago

This PR makes sure that an unsuccessful upload will fail the workflow as this does not happen at the moment. See: https://github.com/open-telemetry/opentelemetry-go/actions/runs/11845773487/job/33011997881?pr=5978#step:3:175

Additionally, it configures the codecov action to be tokenless.

Related issue (most likely solved):

From https://github.com/codecov/codecov-action?tab=readme-ov-file#migration-guide:

The v5 release also coincides with the opt-out feature for tokens for public repositories. In the repository settings page in codecov.io, you can set the ability for Codecov to receive a coverage report from ANY souce. This will allow contributors or other members of a repository to upload without needing access to the Codecov token.

More https://github.com/codecov/codecov-action/issues/1645

v4 was still working. See: https://github.com/open-telemetry/opentelemetry-go/actions/runs/11842872629/job/33002565858#step:3:11 We might also consider reverting to v4 of the codecov action and just setting fail_ci_if_error: true.

pellared commented 1 week ago

After merging we should leave a comment under https://github.com/open-telemetry/community/issues/2440#issuecomment-2477618834 to notify if everything also works fine when the action runs on main branch.

pellared commented 1 week ago

Merging as a trivial change that is supposed to fix the CI.