open-telemetry / opentelemetry-go

OpenTelemetry Go API and SDK
https://opentelemetry.io/docs/languages/go
Apache License 2.0
5.34k stars 1.08k forks source link

Corrent comments for the metric data storage location #5999

Closed yumosx closed 1 day ago

yumosx commented 3 days ago

replace the term "out" with "rm" for better clarity, original comments referred to "out", which can be ambiguous in this contexts

Collect(ctx context.Context, rm *metricdata.ResourceMetrics) error
linux-foundation-easycla[bot] commented 3 days ago

CLA Signed

The committers listed above are authorized under a signed CLA.

dmathieu commented 1 day ago

Yes, that changelog entry may also be removed, I agree.

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.1%. Comparing base (8b510c3) to head (567a8f6). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5999/graphs/tree.svg?width=650&height=150&src=pr&token=8efTmh4kvf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5999?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #5999 +/- ## ===================================== Coverage 82.1% 82.1% ===================================== Files 273 273 Lines 23616 23616 ===================================== + Hits 19400 19402 +2 + Misses 3871 3869 -2 Partials 345 345 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-go/pull/5999/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)

🚨 Try these New Features:

pellared commented 1 day ago

Merging as trivial.