Open TylerHelmuth opened 4 months ago
Hey, i would like to work on this issue.
@suyash-811 Great, we should wait until https://github.com/open-telemetry/opentelemetry-helm-charts/pull/1176 is merged.
Just saw that the PR merged. I'll update the helm template to add the cert-manager annotation if .Values.admissionWebhooks.certManager.enabled=false
I took a look at the template admission-webhooks/operator-webhook-with-cert-manager.yaml
. There is an if
block at the start of the file which also uses the same field from the values file to generate the Webhook configurations (.Values.admissionWebhooks.certManager.enabled
).
Thus, i am a bit unsure if this is the file that really needs the change, as the file isnt rendered at all when the cert-manager admissionWebhook is disabled. Or maybe i got something wrong? Either way, looking forward to some feedback!
@suyash-811 Look for the other places that use the opentelemetry-operator.webhookCertAnnotation
helper template. I believe instead of setting none
we can add more template logic to conditionally add the annotation.
This is going to break make update-operator-crds
and make check-operator-crds
and maybe shouldn't be done until we've got a better way to keep the CRD templates up to date.
Ah i see. I'll prepare a PR for this. It can be merged once CRD management is done.
_Originally posted by @TylerHelmuth in https://github.com/open-telemetry/opentelemetry-helm-charts/pull/1175#discussion_r1595655023_