open-telemetry / opentelemetry-helm-charts

OpenTelemetry Helm Charts
https://opentelemetry.io
Apache License 2.0
397 stars 486 forks source link

Remove required container resources #1312

Closed ba-work closed 2 months ago

ba-work commented 2 months ago

It's currently impossible to deploy the operator chart without requests and/or limits. CPU limits are of particular concern; they are essentially considered harmful at this point.

Additionally, the schema is incomplete by not allowing for (as seen on this page):

  1. spec.containers[].resources.requests.hugepages-<size>
  2. spec.containers[].resources.limits.hugepages-<size>

So I also set additionalProperties to true for the respective limits/requests to support arbitrary hugepage sizes.

This PR allows the user to freely enable, disable or set any value in limits or requests to whatever they want including, most importantly, removing them entirely:

manager:
  resources:
    requests: null
    limits: null
kubeRBACProxy:
  resources:
    requests: null
    limits: null