search

open-telemetry / opentelemetry-helm-charts

OpenTelemetry Helm Charts
https://opentelemetry.io
Apache License 2.0
391 stars 470 forks source link

Keep only two routers in filelog #819

Open VihasMakwana opened 1 year ago

VihasMakwana commented 1 year ago

The CRI-O and contained logs are similar, <timestamp> <stdout|stderr> <logtag> <log message>

The timestamp is of the rfc3339Nano specification. The PR https://github.com/signalfx/splunk-otel-collector-chart/pull/817 has updated the timestamp to rfc3339Nano. I think we can keep two routers only:

One for docker One for cri-o/containerd

We can use the existing cri-o parser. It covers both, Zulu timestamps and timestamps with timezone info.

Related issue: https://github.com/signalfx/splunk-otel-collector-chart/issues/829

VihasMakwana commented 1 year ago

I can work on this one as I'm working on the attached issue

povilasv commented 1 year ago

I like this, this would simplify the config a bit :)

TylerHelmuth commented 1 year ago

Is this a non-breaking change?

VihasMakwana commented 1 year ago

yes, I believe.

VihasMakwana commented 1 year ago

maybe I can roll out a PR and you guy can have a look?

TylerHelmuth commented 1 year ago

Sure. I'm most interested in ensuring that the data the the 2 separate routers were intending to capture really can be capture by the same router.