search

open-telemetry / opentelemetry-helm-charts

OpenTelemetry Helm Charts
https://opentelemetry.io
Apache License 2.0
397 stars 486 forks source link

Add CI scenarios for eBPF Chart #964

Open TylerHelmuth opened 12 months ago

TylerHelmuth commented 12 months ago

Currently the ebpf chart has no CI tests. We should add a test for the default values.yaml at least, but it would be best if we could have more comprehensive coverage.

TylerHelmuth commented 12 months ago

/cc @nicolastakashi

hyfj44255 commented 5 months ago

Hi @TylerHelmuth I would like to have a try if this is still needed, thanks!

nicolastakashi commented 5 months ago

Hi @TylerHelmuth I would like to have a try if this is still needed, thanks!

Go for it @hyfj44255 🙏

hyfj44255 commented 4 months ago

Hi @TylerHelmuth and @nicolastakashi sorry for the delay ,you mentioned that "Currently the ebpf chart has no CI tests",by CI tests do you mean the tests that are ran by CT(helm/chart-testing) like the test cases under charts/opentelemetry-demo/ci ?

nicolastakashi commented 4 months ago

Hey @hyfj44255, yes exactly like that

hyfj44255 commented 2 months ago

Hi @nicolastakashi I created a pr https://github.com/open-telemetry/opentelemetry-helm-charts/pull/1310 would it be ok if you take a look when you got chance? thanks