search

open-telemetry / opentelemetry-java-contrib

https://opentelemetry.io
Apache License 2.0
144 stars 118 forks source link

migrate maven extension to current semconv #1299

Closed SylvainJuge closed 1 month ago

SylvainJuge commented 2 months ago

Description:

Maven extension relies on an older version of semantic conventions and an explicit exception was added in #1070.

This PR aligns maven extension with the new version of semconv.

Replaces #1055 that has become obsolete with current state of semconv.

Overlaps with #1059 but is simpler so easier to review and merge short term.

SylvainJuge commented 2 months ago

Sorry @cyrille-leclerc this probably overlaps quite a lot with your work in this draft PR https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1060 which I just found by browsing the open PRs, however this one might be easier to review and merge by being much simpler and smaller.

SylvainJuge commented 2 months ago

And I also found this other PR: https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1059 from last September where you mentioned having an opt-in option to allow it to continue using current semconv.

However, to my knowledge all other modules in this repo tend to use the current version of semconv.

cyrille-leclerc commented 2 months ago

Thank you very much @SylvainJuge, your PR looks great. I hope the code was enjoyable to read.