search

open-telemetry / opentelemetry-java-instrumentation

OpenTelemetry auto-instrumentation and instrumentation libraries for Java
https://opentelemetry.io
Apache License 2.0
1.96k stars 860 forks source link

Both mongo-3.1 and mongo-3.7 instrumentation have same latestDepTest #1023

Open anuraaga opened 4 years ago

anuraaga commented 4 years ago

When looking at latestDepTest, I noticed that mongo-3.1 and mongo-3.7 both have the same latestDepTest version of +. This is unusual since it means that the old instrumentation works with the newer libraries. From what I can tell, mongo 3.7 instruments a new pattern for building a mongo client. Does it make sense to merge the instrumentation and just test both cases?

trask commented 4 years ago

Changed to required-for-ga with priority p3, to consider it for GA, since it is proposing a change to which instrumentation modules we publish (and I agree the overlap between mongo-3.1 and mongo-3.7 is confusing)

anuraaga commented 4 years ago

couchbase seems to be similar - while latestDepTest isn't exactly the same (spring-data-couchbase version is a bit different, java-client version is same), it seems to have a similar pattern. In fact, 2.6 instrumentation doesn't seem to work without 2.0 instrumentation available which is even more strange and makes merging seem much better.