Support tracing the ClickHouse Java HTTP client - Githubissues

open-telemetry / opentelemetry-java-instrumentation

OpenTelemetry auto-instrumentation and instrumentation libraries for Java

https://opentelemetry.io

Apache License 2.0

1.79k stars 782 forks source link

Support tracing the ClickHouse Java HTTP client #11562

Open devurandom opened 2 weeks ago

devurandom commented 2 weeks ago

Is your feature request related to a problem? Please describe.

ClickHouse Java HTTP client (https://github.com/ClickHouse/clickhouse-java) queries currently show up only as HTTP traces.

Describe the solution you'd like

It would be nice if queries by the ClickHouse Java HTTP client were instrumented like database requests (in addition to the underlying HTTP requests), e.g. with a db.query.text, cf. https://opentelemetry.io/docs/specs/semconv/database/database-spans/.

Describe alternatives you've considered

Automatic HTTP client instrumentation shows that a request happens, but not the query. Relying on them is not an alternative.
Manual instrumentation of code that calls the ClickHouse Java HTTP client. This works, but is inconvenient.

Additional context

No response

laurit commented 2 weeks ago

We'd welcome a contribution for this

jaydeluca commented 2 weeks ago

@devurandom are you planning on contributing this? Otherwise I am interested in working on it.

devurandom commented 2 weeks ago

@devurandom are you planning on contributing this? Otherwise I am interested in working on it.

Please go ahead! :)