search

open-telemetry / opentelemetry-java-instrumentation

OpenTelemetry auto-instrumentation and instrumentation libraries for Java
https://opentelemetry.io
Apache License 2.0
1.89k stars 826 forks source link

Ktor 3.X support #11933

Open FunkyMuse opened 1 month ago

FunkyMuse commented 1 month ago

Is your feature request related to a problem? Please describe.

At the moment the Ktor 3.X open telemetry is not supported and the 2.0 support just doesn't work with Ktor 3.0

Describe the solution you'd like

It would be awesome to support Ktor open telemetry with target at ktor 3.X, even if it's in Beta 02 the compatibility with Kotlin 2.0 have already landed

Describe alternatives you've considered

None, as the migration to something else other than open telemetry doesn't make it feasible for us to do so.

Additional context

No response

trask commented 1 month ago

cc @marychatte

FunkyMuse commented 1 week ago

Maybe create a PR if not added by open telemetry

acunap commented 1 week ago

https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/10873 done few months ago but it's not merged yet

FunkyMuse commented 1 week ago

10873 done few months ago but it's not merged yet

why did you delete the PR? :/

acunap commented 1 day ago

10873 done few months ago but it's not merged yet

why did you delete the PR? :/

Tbh I was cleaning my repos and I accidentally deleted it 😆 In any case I don't think it was going to be merged and better to wait for Ktor's official solution.