search

open-telemetry / opentelemetry-java-instrumentation

OpenTelemetry auto-instrumentation and instrumentation libraries for Java
https://opentelemetry.io
Apache License 2.0
1.99k stars 868 forks source link

Ktor 3.X support #11933

Closed FunkyMuse closed 1 week ago

FunkyMuse commented 3 months ago

Is your feature request related to a problem? Please describe.

At the moment the Ktor 3.X open telemetry is not supported and the 2.0 support just doesn't work with Ktor 3.0

Describe the solution you'd like

It would be awesome to support Ktor open telemetry with target at ktor 3.X, even if it's in Beta 02 the compatibility with Kotlin 2.0 have already landed

Describe alternatives you've considered

None, as the migration to something else other than open telemetry doesn't make it feasible for us to do so.

Additional context

No response

trask commented 3 months ago

cc @marychatte

FunkyMuse commented 2 months ago

Maybe create a PR if not added by open telemetry

acunap commented 2 months ago

https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/10873 done few months ago but it's not merged yet

FunkyMuse commented 2 months ago

10873 done few months ago but it's not merged yet

why did you delete the PR? :/

acunap commented 2 months ago

10873 done few months ago but it's not merged yet

why did you delete the PR? :/

Tbh I was cleaning my repos and I accidentally deleted it 😆 In any case I don't think it was going to be merged and better to wait for Ktor's official solution.

FunkyMuse commented 1 month ago

Ktor 3.0.0 is released

steverao commented 1 month ago

Ktor 3.0.0 is released

Yes, we noticed it. We'd welcome a contribution for this.

FunkyMuse commented 1 month ago

Ktor 3.0.0 is released

Yes, we noticed it. We'd welcome a contribution for this.

https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/12453

inakov commented 1 week ago

Hey, guys is there any update on this ticket? Support from open telemetry is the only thing that block us for migrations to ktor 3. Do you have any ideas what have left and when we can expect this?

FunkyMuse commented 1 week ago

Support has been released with their latest alpha release, I've already integrated otel and running jaeger in prod.