search

open-telemetry / opentelemetry-java-instrumentation

OpenTelemetry auto-instrumentation and instrumentation libraries for Java
https://opentelemetry.io
Apache License 2.0
1.96k stars 858 forks source link

Fix context leaks in existing tests #3916

Open trask opened 3 years ago

trask commented 3 years ago

This is a tracking issue to fix context leaks in existing tests for all instrumentations that currently have to disable the strict context check.

trask commented 3 years ago

Starting to track associated errors in case they are useful:

Elasticsearch6NodeClientTest > test elasticsearch get[0] FAILED 
    java.lang.AssertionError: Thread [elasticsearch[default node name][masterService#updateTask][T#1]] opened a scope of {opentelemetry-trace-span-key=RecordEventsReadableSpan{traceId=1551d3e6b043be93c1b2dbd4457d9ba9, spanId=620f959ffafc836a, parentSpanContext=ImmutableSpanContext{traceId=00000000000000000000000000000000, spanId=0000000000000000, traceFlags=00, traceState=ArrayBasedTraceState{entries=[]}, remote=false, valid=false}, name=DeleteIndexAction, kind=CLIENT, attributes=AttributesMap{data={db.system=elasticsearch, elasticsearch.request.indices=test-index, elasticsearch.action=DeleteIndexAction, elasticsearch.request=DeleteIndexRequest, db.operation=DeleteIndexAction}, capacity=128, totalAddedValues=5}, status=ImmutableStatusData{statusCode=UNSET, description=}, totalRecordedEvents=0, totalRecordedLinks=0, startEpochNanos=1629767596124752000, endEpochNanos=1629767596169849223}, opentelemetry-traces-span-key-client=RecordEventsReadableSpan{traceId=1551d3e6b043be93c1b2dbd4457d9ba9, spanId=620f959ffafc836a, parentSpanContext=ImmutableSpanContext{traceId=00000000000000000000000000000000, spanId=0000000000000000, traceFlags=00, traceState=ArrayBasedTraceState{entries=[]}, remote=false, valid=false}, name=DeleteIndexAction, kind=CLIENT, attributes=AttributesMap{data={db.system=elasticsearch, elasticsearch.request.indices=test-index, elasticsearch.action=DeleteIndexAction, elasticsearch.request=DeleteIndexRequest, db.operation=DeleteIndexAction}, capacity=128, totalAddedValues=5}, status=ImmutableStatusData{statusCode=UNSET, description=}, totalRecordedEvents=0, totalRecordedLinks=0, startEpochNanos=1629767596124752000, endEpochNanos=1629767596169849223}, thread-propagation-locations=[io.opentelemetry.javaagent.shaded.instrumentation.api.internal.ContextPropagationDebug$Propagation@79bf0709, io.opentelemetry.javaagent.shaded.instrumentation.api.internal.ContextPropagationDebug$Propagation@1c0ecb4a, io.opentelemetry.javaagent.shaded.instrumentation.api.internal.ContextPropagationDebug$Propagation@77f12823, io.opentelemetry.javaagent.shaded.instrumentation.api.internal.ContextPropagationDebug$Propagation@5fb2b87c, io.opentelemetry.javaagent.shaded.instrumentation.api.internal.ContextPropagationDebug$Propagation@2ec7a995, io.opentelemetry.javaagent.shaded.instrumentation.api.internal.ContextPropagationDebug$Propagation@647e7df7, io.opentelemetry.javaagent.shaded.instrumentation.api.internal.ContextPropagationDebug$Propagation@36fc70c8, io.opentelemetry.javaagent.shaded.instrumentation.api.internal.ContextPropagationDebug$Propagation@5cfd2a98, io.opentelemetry.javaagent.shaded.instrumentation.api.internal.ContextPropagationDebug$Propagation@53627011, io.opentelemetry.javaagent.shaded.instrumentation.api.internal.ContextPropagationDebug$Propagation@7bf1362d]} here:    
        at io.opentelemetry.javaagent.instrumentation.api.concurrent.TaskAdviceHelper.makePropagatedContextCurrent(TaskAdviceHelper.java:27)    
        at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.run(PrioritizedEsThreadPoolExecutor.java:198)    
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)    
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)    
        at java.base/java.lang.Thread.run(Thread.java:829)
trask commented 3 years ago 
Mongo4ReactiveClientTest > test create collection FAILED    
    java.lang.AssertionError: Thread [AsyncGetter-1-thread-1] opened a scope of {opentelemetry-trace-span-key=RecordEventsReadableSpan{traceId=342add72e4a4ec95c7cc41621f324771, spanId=4a73de3e7903d89d, parentSpanContext=ImmutableSpanContext{traceId=00000000000000000000000000000000, spanId=0000000000000000, traceFlags=00, traceState=ArrayBasedTraceState{entries=[]}, remote=false, valid=false}, name=parent, kind=INTERNAL, attributes=null, status=ImmutableStatusData{statusCode=UNSET, description=}, totalRecordedEvents=0, totalRecordedLinks=0, startEpochNanos=1629771066420432133, endEpochNanos=1629771067201377940}, otel-context={}, thread-propagation-locations=[io.opentelemetry.javaagent.shaded.instrumentation.api.internal.ContextPropagationDebug$Propagation@43cae8d3]} here:   
        at io.opentelemetry.javaagent.instrumentation.api.concurrent.TaskAdviceHelper.makePropagatedContextCurrent(TaskAdviceHelper.java:27)    
        at io.opentelemetry.javaagent.instrumentation.api.concurrent.RunnableWrapper.run(RunnableWrapper.java:38)   
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)    
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)   
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)    
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)    
        at java.base/java.lang.Thread.run(Thread.java:829)