open-telemetry / opentelemetry-java-instrumentation

OpenTelemetry auto-instrumentation and instrumentation libraries for Java
https://opentelemetry.io
Apache License 2.0
1.81k stars 791 forks source link

Add support for apache nifi integration #6090

Open bputt-e opened 2 years ago

bputt-e commented 2 years ago

Is your feature request related to a problem? Please describe. We're looking to add tracing to Apache NiFi and are weighing options of adding an otel implementation within NiFi or seeing if auto instrumentation is more feasible

Describe the solution you'd like Apache NiFi uses spring under the hood, ideally this adds some additional implementation that supports NiFi

Describe alternatives you've considered We're investigating this as an option vs adding manual instrumentation into Apache NiFi

Additional context Apache NiFi can become a little complex...Given the most basic example, imagine if you had two files come in, both files have different traceIds. We decide to merge those files into a single file, what traceId/parentId gets set to the single file?

trask commented 2 years ago

hi @bputt-e! if you are able to drop by the OpenTelemetry Java meeting tomorrow at 9am Pacific (and there's also a meeting at 6pm Pacific) that would be a great time to chat through options https://calendar.google.com/calendar/u/0/embed?src=google.com_b79e3e90j7bbsa2n2p5an5lf60@group.calendar.google.com

or if you can describe your initial thoughts/ideas here we can try to provide some pointers/guidance

bputt-e commented 2 years ago

@trask I will come to your 6pm Pacific meeting on June 2

trask commented 11 months ago

hey @bputt-e! just doing some issue triage, how's this going? thx

bputt-e commented 11 months ago

hello @trask it's going well, we created a proof of concept originally w/ byte buddy and are now migrating it to the java-instrumentation code base, hoping to submit a pr in the next ~4 weeks

bputt-e commented 11 months ago

@trask would you or other contributors be able to support a call to go over our instrumentation to help answer some issues we're running into during the build? we could present it at next thursday's meeting, but figured it'd take up too much of the meeting

mateuszrzeszutek commented 11 months ago

Hey @bputt-e , This kind of thing is exactly what the SIG meeting is supposed to be used for -- don't worry about taking up too much time, go ahead and join the Thu meeting.

trask commented 11 months ago

I added it to the top of the agenda

benhason1 commented 8 months ago

Hi, @bputt-e is there any update about the pr? We would love to use youre open telemetry Nifi processor.

bputt-e commented 8 months ago

@benhason1 we're prob about 3 - 4 weeks away from getting approval to release the source code, which even then, we'll need some help from OTEL on fixing the build for older versions of nifi

Doron-Bargo commented 8 months ago

@bputt-e did you though on using the provenance log to achieve the same goal?

bputt-e commented 8 months ago

@Doron-Bargo we didn't want to force people to turn on provenance in order to achieve tracing, plus we wanted to ensure tracing propagated from nifi to nifi and/or nifi to http/kafka/jms/etc... using the traceparent header

Doron-Bargo commented 8 months ago

Amazing @bputt-e are we still in the previous timelines - around 2 weeks from now?

bputt-e commented 7 months ago

@Doron-Bargo yes, just waiting on approval to release

Doron-Bargo commented 7 months ago

Thanks is there a pr for it? So we can follow

bputt-e commented 7 months ago

@Doron-Bargo nope, can't release code until we get approval

galbash commented 2 weeks ago

A bit late to the party but just in case this is still relevant: https://github.com/galbash/otel-nifi-extension (version 1.22.0)

fuzolan commented 2 weeks ago

A bit late to the party but just in case this is still relevant: https://github.com/galbash/otel-nifi-extension (version 1.22.0)

This would be great in the nifi core as a configured service