Getters vs extractors: where should we draw the line?

open-telemetry / opentelemetry-java-instrumentation

OpenTelemetry auto-instrumentation and instrumentation libraries for Java

https://opentelemetry.io

Apache License 2.0

1.92k stars 842 forks source link

Getters vs extractors: where should we draw the line? #8246

Open mateuszrzeszutek opened 1 year ago

mateuszrzeszutek commented 1 year ago

Linking the original discussion: https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/8131#discussion_r1157375072

breedx-splk commented 1 year ago

Have your thoughts on this changed at all in the last 4+ months? What do you wanna do about this issue?

mateuszrzeszutek commented 1 year ago

Have your thoughts on this changed at all in the last 4+ months?

Not really. I still think that we should encapsulate the bulk of the semconv logic in the extractors, and the getter should just map our concepts to instrumented library concepts. @trask WDYT?