open-telemetry / opentelemetry-java-instrumentation

OpenTelemetry auto-instrumentation and instrumentation libraries for Java
https://opentelemetry.io
Apache License 2.0
1.92k stars 839 forks source link

A plan for opentelemetry-java-instrumentation to support JDK 20? #9505

Closed sadadw1 closed 2 months ago

sadadw1 commented 1 year ago

Is your feature request related to a problem? Please describe.

Does opentelemetry-java-instrumentation plan to support JDK 20? Specifically:

  1. JVM support for ZGC monitoring.
  2. Previously, traces were chained between Threads, but now there's a need to propagate them between coroutines.
  3. opentelemetry-java-instrumentation used to internally store Context using ThreadLocal. However, in the context of coroutines, ThreadLocal is not an ideal solution.

Describe the solution you'd like

opentelemetry-java-instrumentation support JDK 20

Describe alternatives you've considered

No response

Additional context

No response

tylerbenson commented 1 year ago

For clarification, by coroutines do you mean virtual threads?

trask commented 1 year ago

hi @sadadw1! we discussed in the weekly Java meeting today and I added notes here: #9534

I wasn't clear about some of your points above though, can you expand here in this issue of anything not mentioned in #9534? thx!

sadadw1 commented 1 year ago

For clarification, by coroutines do you mean virtual threads?

yes, you are right

SylvainJuge commented 3 months ago

Hi @sadadw1 , as @trask mentioned in his last comment support for virtual threads (and also the thread-local) is already described in #9534 , could you describe what do you mean exactly with JVM support for ZGC monitoring. ?

In general, if there is something to change it's better to keep track in a separate issue as work and progress on both topics might not be done at the same time.

github-actions[bot] commented 3 months ago

This has been automatically marked as stale because it has been marked as needing author feedback and has not had any activity for 7 days. It will be closed automatically if there is no response from the author within 7 additional days from this comment.