open-telemetry / opentelemetry-java-instrumentation

OpenTelemetry auto-instrumentation and instrumentation libraries for Java
https://opentelemetry.io
Apache License 2.0
1.91k stars 834 forks source link

Unify metric collection between JMX Metrics Gatherer and JMX Metrics Insight #9765

Open mackjmr opened 11 months ago

mackjmr commented 11 months ago

Is your feature request related to a problem? Please describe.

JMX Metrics Insight was initially built as a replacement to JMX Metric Gatherer for the following reasons (#6131):

The end goal of collecting JMX data is the same, only the approach changes. However, today these options cannot be used as replacements, as the two options collect metrics from different target systems, and and collect different metrics within target systems.

Describe the solution you'd like

Unify metrics collected between the JMX Metrics Insight and JMX Metric Gatherer, meaning:

Keeping both in sync manually is not a good solution, as this requires high maintaining efforts and is error prone. Creating a shared metric package to define target systems and metrics to collect will solve this issue. This will make updating metrics in one place apply to both solutions, and ensure that users have a consistent experience based on the option they choose.

Describe alternatives you've considered

No response

Additional context

No response

trask commented 11 months ago

see also https://github.com/open-telemetry/opentelemetry-java-contrib/issues/736