Open Flarna opened 1 year ago
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.
Hey @Flarna, not sure if I can pick this task?
When working on this, should we split it into multiple PR for each framework?
Sure, feel free to start. I haven't found time to start.
I would start a PR for one framework and once the way how to do it is agree do the remaining ones.
Current status:
We've merged in the change for Express but it looks like there were some unexpected issues that came up. Let's double check these other PRs for Restify, Fastify, Hapi, and Koa to see if we can update those before they are merged in if they have the same problem.
@JamieDanielson Yes, I double check and koa seem to have the same issue
I just push a fix for that.
HTTP_ROUTE
propagation from HTTP server frameworks to HTTP span is inconsistent:rpcData
where Http instrumentation pickes it upHTTP_ROUTE
directly on HTTP spanI think all frameworks should avoid modifications of the HTTP span directly instead return the
route
info viarpcData
and leave it up to the HTTP instrumentation to build the final span name and set theHTTP_ROUTE
attribute.Setting
HTTP_ROUTE
directly breaks for example the assumption done in this PR.