trentm
commented
7 months ago notes on fastify ESM support
Fastify ESM support is slightly limited. The current import style in "opentelemetry-js-contrib/plugins/node/opentelemetry-instrumentation-fastify/test/fixtures/use-fastify.mjs" works, but this fails:
...
import * as mod from 'fastify';
console.log('mod: ', mod);
const app = mod.fastify();
...Here mod.default is instrumented, but mod.fastify is not.
This is probably an exceedingly rare way to import and use fastify. Still,
this is why I haven't checked fastify above.
tobiasmuehl
This is a meta issue to coordinate doing a first pass at ECMAScript module (ESM) support and a test for every node.js instrumentation. (This is about working with the
import-in-the-middle-based hook so is not relevant to browser instrumentations.) I'm not necessarily volunteering to do all these :), but I'll certainly help.Hopefully this can also be useful for support/help requests for why instrumentation might not be working for ESM-using code. If the module/instrumentation in question is not checked off here, then ESM instrumentation is not expected to work (it might be luck).
dev notes
Run the following to show which (contrib-repo) instrumentations have an ESM-related test. This shows usage of the required experimental-loader hook to support hooking ESM modules.
Guide on adding ESM support and an ESM test to an instrumentation
TODO(trentm)
runTestFixture