search

open-telemetry / opentelemetry-js

OpenTelemetry JavaScript Client
https://opentelemetry.io
Apache License 2.0
2.71k stars 789 forks source link

improv(tests): add e2e test with collector for all of our OTLP exporters #2157

Open vmarchaud opened 3 years ago

vmarchaud commented 3 years ago

After changing the default port I can assume it will not be working. Could you please update the docker to ensure it is still working fine (use the latest docker image 0.25)?

Sure, but i think it would make sense to make test with the collector (end to end pretty much) itself in our pipeline so this doesn't require manual testing in the future

Originally posted by @vmarchaud in https://github.com/open-telemetry/opentelemetry-js/issues/2117#issuecomment-824831352

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

JamieDanielson commented 11 months ago

We've had some success using jq and bats for testing our distros at Honeycomb, and also added it to the opentelemetry-go-instrumentation project. Wonder if there is appetite to have the same thing here?

Basically we spin up an app and a collector in docker, export to a file, and make assertions on the output. I wrote a bit of detail here on a small blog post, and here is an example test in our JS distro. I would be happy to help with this effort if it seems like a reasonable path forward.

pichlermarc commented 2 days ago

@JamieDanielson this sounds like a great idea 🙂

I'm adding the blocked label as I'm currently modifying some of the existing tests and I want to ensure that nobody is working on this (this will likely lead to conflicts). I still think that we should do this, tough (ideally before releasing a GA version of the OTLP exporters).