open-telemetry / opentelemetry-js

OpenTelemetry JavaScript Client
https://opentelemetry.io
Apache License 2.0
2.76k stars 810 forks source link

Metrics examplars #2594

Closed dyladan closed 1 week ago

dyladan commented 3 years ago

Spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#exemplar

A metrics exemplar is a trace that is representative of the metrics being collected. The spec requires that exemplars be implemented in a way such that they may be disabled and that if disabled they should have no performance impact (collection should be disabled, not just export). When enabled, the exemplars will come from the currently active context.

Properties:

Built-in reservoirs

srikanthccv commented 3 years ago

Happy to take this up if no one has already started working on it

dyladan commented 3 years ago

go ahead. You may want to keep an eye on #2625 since it changes what we have quite a bit

legendecas commented 2 years ago

@lonewolf3739 a friendly question: are you planning to work on the integration of metric exemplars and the View API?

srikanthccv commented 2 years ago

@legendecas yes, that's why I didn't use fixes in the PR description that would close this issue. And there is also tiny env related work to do. I will work on the wiring up the stuff as well when other components are ready.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

pichlermarc commented 2 years ago

Hi @srikanthccv :slightly_smiling_face:

Friendly question: are you still planning to work on this? :thinking: Otherwise I'll mark this as up-for-grabs in case someone else has some cycles to work on it. :slightly_smiling_face:

srikanthccv commented 2 years ago

@pichlermarc I won't be able to allocate time for this - unassigning myself. Thanks.

vothanhbinhlt commented 2 years ago

Hello team, any update on this? I am waiting for this feature, I am would like to setup a Nodejs application work with Exemplars, Prometheus and Tempo

pichlermarc commented 2 years ago

AFAIK no one is currently working on this. Interest in it might pick up once the specification is marked stable.

antogyn commented 1 week ago

Hey, is there any way to sponsor this? We'd like to switch to the sdk for metrics but this is a blocker.

pichlermarc commented 1 week ago

@antogyn this issue is looking for someone to implement it.

It's a feature that's in the OTel spec, so it does not need to go through any special approval process. We will accept code-contributions if someone decides to implement it, unless it's submitted within a feature-freeze period (the first of which is coming up mid December).

pichlermarc commented 1 week ago

Hi all, I will close this feature-request as ACCEPTED since the specification is now stable.

This means that it has been refined into a concrete work-item (#5147). Implementation progress will be tracked on #5147 from here on out. I marked it as type:feature rather than feature-reuqest to ensure that it's clear that this is a feature that is accepted and can be worked on.