open-telemetry / opentelemetry-js

OpenTelemetry JavaScript Client
https://opentelemetry.io
Apache License 2.0
2.69k stars 779 forks source link

add auto instrumentation of http2 module #2667

Open SunilManthenaG01 opened 2 years ago

SunilManthenaG01 commented 2 years ago

What version of OpenTelemetry are you using?

"@opentelemetry/api": "^1.0.3", "@opentelemetry/auto-instrumentations-node": "^0.27.0", "@opentelemetry/sdk-node": "^0.27.0", "@opentelemetry/sdk-trace-base": "^1.0.1",

What version of Node are you using?

14.16.1

What did you do?

I created a trace.js file with auto instrumentation and console exporter. When the server is listening to HTTP/HTTPS 1.1, I can see the trace in console.log but when I switch to the http2 server protocol I cant see the traces.

What did you expect to see?

Even with http 2, i should be able to see the trace.

What did you see instead?

Nothing

Additional context

https://github.com/SunilManthenaG01/open-tel-http-2-issue

I create a sample repo for reproducing the issue. where i have one file implemented with http 1.1 and another one with http 2.

SunilManthenaG01 commented 2 years ago

Does anyone have any input on this issue?

Flarna commented 2 years ago

There is currently no instrumentation for the node.js http2 module - only for the http module. So you either have to manually create the spans in your app or contribute an instrumentation.

Edit: remove the bug label as this is know to be not supported so it's no bug it's a feature you would like to have.

vmarchaud commented 2 years ago

I'll go ahead ang move this issue to the core repo seems the instrumentation will most likely go there

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

carolabadeer commented 1 year ago

Hello! Any updates on when this will be picked up or prioritized?

raphael-theriault-swi commented 1 year ago

Currently looking into this one

adelsz commented 3 weeks ago

This would be great, as HTTP2 isn't exactly rare these days.