Disallow `new Span()` - Githubissues

open-telemetry / opentelemetry-js

OpenTelemetry JavaScript Client

https://opentelemetry.io

Apache License 2.0

2.65k stars 765 forks source link

Disallow `new Span()` #3597

Open dyladan opened 1 year ago

dyladan commented 1 year ago

Currently it is possible to call new Span(). We should make the constructor private to disallow this.

Current test usages:

1 use of new span in contrib tests: https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/plugins/node/opentelemetry-instrumentation-dns/test/functionals/utils.test.ts#L150
? uses of new Span in JS tests
honeycomb distro is known to use Span in tests
dd-trace may also use new Span in tests? @dyladan will look into this

Possible additional goals:

do not use a class for span (improve minification)
create test utility library

JamieDanielson commented 1 month ago

Note: To do this, we can make Span private and for TypeScript we should be able to access with obj[“somePrivateProperty”]