Open dyladan opened 8 months ago
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.
@dyladan I'm currently refining issues, one question:
@opentelemetry/context-async-hooks
to @opentelemetry/context-async-local-storage
as it'll be the only context manager that's left in that package?If yes, then I think we can break this down into multiple subtasks:
AsyncHooksContextManager
to AsyncLocalStorageContextManager
@opentelemetry/context-async-local-storage
AbstractAsyncHooksContextManager
into AsyncLocalStorageContextManager
Actually if we're going to do a rename we might be able to do this without breaking. I didn't even think of that. Do you think context-async-local-storage
or context-node
?
Actually if we're going to do a rename we might be able to do this without breaking. I didn't even think of that. Do you think
context-async-local-storage
orcontext-node
?
I think @opentelemetry/context-node
may work.
So we'd do this:
@opentelemetry/context-node
AsyncLocalStorageContextManager
to @opentelemetry/context-node
and integrate the Abstract Base into that class@opentelemetry/context-async-hooks
, refer to @opentelemetry/context-node
and that it is the new one@opentelemetry/context-async-hooks
in NPM and remove the package from the repoThen no tasks are left that are actually breaking and we can remove this issue from the milestone. WDYT @dyladan? If you agree then I'll create issues for the sub-tasks for contributors to pick up. Should be fairly easy tasks.
Originally posted by @dyladan in https://github.com/open-telemetry/opentelemetry-js/issues/3720#issuecomment-1823194259
No longer used in SDK 2.0 so it can be safely removed.