open-telemetry / opentelemetry-js

OpenTelemetry JavaScript Client
https://opentelemetry.io
Apache License 2.0
2.64k stars 762 forks source link

Remove unused `AsyncHooksContextManager` #4364

Open dyladan opened 8 months ago

dyladan commented 8 months ago
          Also consider remove `AsyncHooksContextManager` because it will no longer be used.

Originally posted by @dyladan in https://github.com/open-telemetry/opentelemetry-js/issues/3720#issuecomment-1823194259

No longer used in SDK 2.0 so it can be safely removed.

github-actions[bot] commented 6 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

pichlermarc commented 6 months ago

@dyladan I'm currently refining issues, one question:

If yes, then I think we can break this down into multiple subtasks:

dyladan commented 3 months ago

Actually if we're going to do a rename we might be able to do this without breaking. I didn't even think of that. Do you think context-async-local-storage or context-node?

pichlermarc commented 2 months ago

Actually if we're going to do a rename we might be able to do this without breaking. I didn't even think of that. Do you think context-async-local-storage or context-node?

I think @opentelemetry/context-node may work.

So we'd do this:

Then no tasks are left that are actually breaking and we can remove this issue from the milestone. WDYT @dyladan? If you agree then I'll create issues for the sub-tasks for contributors to pick up. Should be fairly easy tasks.