open-telemetry / opentelemetry-js

OpenTelemetry JavaScript Client
https://opentelemetry.io
Apache License 2.0
2.69k stars 773 forks source link

New Labels Request - `propagator: aws:xray` and `propagator: aws:xray:lambda` #4964

Open jj22ee opened 1 month ago

jj22ee commented 1 month ago

Hello, I'm reaching out on behalf of the AWS X-Ray team. We would like to request the addition of new labels to opentelemetry-js repository: propagator: aws:xray and propagator: aws:xray:lambda. These labels would be used for PRs and issues pertaining to the X-Ray Propagator and X-Ray Lambda Propagator. Ideally, there would be automation that adds these labels to PRs touching X-Ray component code - we would be happy to help with this if some guidance was provided.

Our goal is to have labelling across open-telemetry repositories so that we can find PRs and issues related to the X-Ray components and give faster support to the OTEL community.

Thank you.

pichlermarc commented 1 month ago

Hi @jj22ee thanks for reaching out. We've been meaning to move the propagators to the js-contrib repo for a while now as we saw that hosting vendor components in the here in the core repo is not spec compliant.

I've opened a PR to add them to contrib https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2411 as well as a PR to remove them from the core repository here https://github.com/open-telemetry/opentelemetry-js/pull/4966 (marked as draft for now until the contrib PR is merged). In the repository over there, we have some auto-labelling workflow that applies pkg:propagator-aws-xray and pkg:propagator-aws-xray-lambda labels. Would these work for you?