search

open-telemetry / opentelemetry-js

OpenTelemetry JavaScript Client
https://opentelemetry.io
Apache License 2.0
2.68k stars 772 forks source link

refactor(sdk-metrics)!: replace `MetricsAttributes` with `Attributes` #5020

Closed david-luna closed 1 day ago

david-luna commented 1 day ago

Which problem is this PR solving?

Replaces MetricsAttributes with Attributes

Refs #4175

Short description of the changes

Replace the interfaces in sources & tests. This PR targeting next since the changes in exported APIs make it a breaking change.

How Has This Been Tested?

at the root folder

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.96%. Comparing base (32564ad) to head (b997967). Report is 3 commits behind head on next.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #5020 +/- ## ======================================= Coverage 93.96% 93.96% ======================================= Files 310 310 Lines 8147 8147 Branches 1630 1630 ======================================= Hits 7655 7655 Misses 492 492 ``` | [Files with missing lines](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5020?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [packages/sdk-metrics/src/Instruments.ts](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5020?src=pr&el=tree&filepath=packages%2Fsdk-metrics%2Fsrc%2FInstruments.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-cGFja2FnZXMvc2RrLW1ldHJpY3Mvc3JjL0luc3RydW1lbnRzLnRz) | `96.00% <100.00%> (ø)` | | | [packages/sdk-metrics/src/ObservableResult.ts](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5020?src=pr&el=tree&filepath=packages%2Fsdk-metrics%2Fsrc%2FObservableResult.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-cGFja2FnZXMvc2RrLW1ldHJpY3Mvc3JjL09ic2VydmFibGVSZXN1bHQudHM=) | `100.00% <100.00%> (ø)` | | | [packages/sdk-metrics/src/aggregator/types.ts](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5020?src=pr&el=tree&filepath=packages%2Fsdk-metrics%2Fsrc%2Faggregator%2Ftypes.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-cGFja2FnZXMvc2RrLW1ldHJpY3Mvc3JjL2FnZ3JlZ2F0b3IvdHlwZXMudHM=) | `100.00% <ø> (ø)` | | | [...xemplar/AlignedHistogramBucketExemplarReservoir.ts](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5020?src=pr&el=tree&filepath=packages%2Fsdk-metrics%2Fsrc%2Fexemplar%2FAlignedHistogramBucketExemplarReservoir.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-cGFja2FnZXMvc2RrLW1ldHJpY3Mvc3JjL2V4ZW1wbGFyL0FsaWduZWRIaXN0b2dyYW1CdWNrZXRFeGVtcGxhclJlc2Vydm9pci50cw==) | `92.30% <ø> (ø)` | | | [...metrics/src/exemplar/AlwaysSampleExemplarFilter.ts](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5020?src=pr&el=tree&filepath=packages%2Fsdk-metrics%2Fsrc%2Fexemplar%2FAlwaysSampleExemplarFilter.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-cGFja2FnZXMvc2RrLW1ldHJpY3Mvc3JjL2V4ZW1wbGFyL0Fsd2F5c1NhbXBsZUV4ZW1wbGFyRmlsdGVyLnRz) | `100.00% <ø> (ø)` | | | [...ages/sdk-metrics/src/exemplar/ExemplarReservoir.ts](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5020?src=pr&el=tree&filepath=packages%2Fsdk-metrics%2Fsrc%2Fexemplar%2FExemplarReservoir.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-cGFja2FnZXMvc2RrLW1ldHJpY3Mvc3JjL2V4ZW1wbGFyL0V4ZW1wbGFyUmVzZXJ2b2lyLnRz) | `95.65% <100.00%> (ø)` | | | [...-metrics/src/exemplar/NeverSampleExemplarFilter.ts](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5020?src=pr&el=tree&filepath=packages%2Fsdk-metrics%2Fsrc%2Fexemplar%2FNeverSampleExemplarFilter.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-cGFja2FnZXMvc2RrLW1ldHJpY3Mvc3JjL2V4ZW1wbGFyL05ldmVyU2FtcGxlRXhlbXBsYXJGaWx0ZXIudHM=) | `100.00% <ø> (ø)` | | | [...s/src/exemplar/SimpleFixedSizeExemplarReservoir.ts](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5020?src=pr&el=tree&filepath=packages%2Fsdk-metrics%2Fsrc%2Fexemplar%2FSimpleFixedSizeExemplarReservoir.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-cGFja2FnZXMvc2RrLW1ldHJpY3Mvc3JjL2V4ZW1wbGFyL1NpbXBsZUZpeGVkU2l6ZUV4ZW1wbGFyUmVzZXJ2b2lyLnRz) | `77.77% <ø> (ø)` | | | [...dk-metrics/src/exemplar/WithTraceExemplarFilter.ts](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5020?src=pr&el=tree&filepath=packages%2Fsdk-metrics%2Fsrc%2Fexemplar%2FWithTraceExemplarFilter.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-cGFja2FnZXMvc2RrLW1ldHJpY3Mvc3JjL2V4ZW1wbGFyL1dpdGhUcmFjZUV4ZW1wbGFyRmlsdGVyLnRz) | `100.00% <ø> (ø)` | | | [packages/sdk-metrics/src/export/MetricData.ts](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5020?src=pr&el=tree&filepath=packages%2Fsdk-metrics%2Fsrc%2Fexport%2FMetricData.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-cGFja2FnZXMvc2RrLW1ldHJpY3Mvc3JjL2V4cG9ydC9NZXRyaWNEYXRhLnRz) | `100.00% <ø> (ø)` | | | ... and [5 more](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5020?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | |
david-luna commented 1 day ago

actually this can target main as commented in https://github.com/open-telemetry/opentelemetry-js/issues/4175#issuecomment-2354025623

new PR: https://github.com/open-telemetry/opentelemetry-js/pull/5021