open-telemetry / opentelemetry-js

OpenTelemetry JavaScript Client
https://opentelemetry.io
Apache License 2.0
2.76k stars 810 forks source link

chore(resources): update semconv usage to modern ATTR_ export names #5187

Open trentm opened 5 days ago

trentm commented 5 days ago

Refs: https://github.com/open-telemetry/opentelemetry-js/issues/4896

status

This is in draft while we discuss how to handle using unstable semconv attributes: (1) use the incubating entry-point or (2) make local copies of the unstable constants. See https://github.com/open-telemetry/opentelemetry-js/issues/5182#issuecomment-2489385179

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.59%. Comparing base (e97cc2e) to head (f89b10a).

Files with missing lines Patch % Lines
...try-resources/src/detectors/BrowserDetectorSync.ts 0.00% 1 Missing :warning:
...lemetry-resources/src/detectors/EnvDetectorSync.ts 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5187 +/- ## ========================================== + Coverage 94.58% 94.59% +0.01% ========================================== Files 314 315 +1 Lines 7993 8008 +15 Branches 1611 1611 ========================================== + Hits 7560 7575 +15 Misses 433 433 ``` | [Files with missing lines](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5187?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [packages/opentelemetry-resources/src/Resource.ts](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5187?src=pr&el=tree&filepath=packages%2Fopentelemetry-resources%2Fsrc%2FResource.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-cGFja2FnZXMvb3BlbnRlbGVtZXRyeS1yZXNvdXJjZXMvc3JjL1Jlc291cmNlLnRz) | `100.00% <ø> (ø)` | | | [...es/src/detectors/platform/node/HostDetectorSync.ts](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5187?src=pr&el=tree&filepath=packages%2Fopentelemetry-resources%2Fsrc%2Fdetectors%2Fplatform%2Fnode%2FHostDetectorSync.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-cGFja2FnZXMvb3BlbnRlbGVtZXRyeS1yZXNvdXJjZXMvc3JjL2RldGVjdG9ycy9wbGF0Zm9ybS9ub2RlL0hvc3REZXRlY3RvclN5bmMudHM=) | `100.00% <100.00%> (ø)` | | | [...rces/src/detectors/platform/node/OSDetectorSync.ts](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5187?src=pr&el=tree&filepath=packages%2Fopentelemetry-resources%2Fsrc%2Fdetectors%2Fplatform%2Fnode%2FOSDetectorSync.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-cGFja2FnZXMvb3BlbnRlbGVtZXRyeS1yZXNvdXJjZXMvc3JjL2RldGVjdG9ycy9wbGF0Zm9ybS9ub2RlL09TRGV0ZWN0b3JTeW5jLnRz) | `100.00% <100.00%> (ø)` | | | [...src/detectors/platform/node/ProcessDetectorSync.ts](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5187?src=pr&el=tree&filepath=packages%2Fopentelemetry-resources%2Fsrc%2Fdetectors%2Fplatform%2Fnode%2FProcessDetectorSync.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-cGFja2FnZXMvb3BlbnRlbGVtZXRyeS1yZXNvdXJjZXMvc3JjL2RldGVjdG9ycy9wbGF0Zm9ybS9ub2RlL1Byb2Nlc3NEZXRlY3RvclN5bmMudHM=) | `92.85% <100.00%> (ø)` | | | [...ors/platform/node/ServiceInstanceIdDetectorSync.ts](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5187?src=pr&el=tree&filepath=packages%2Fopentelemetry-resources%2Fsrc%2Fdetectors%2Fplatform%2Fnode%2FServiceInstanceIdDetectorSync.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-cGFja2FnZXMvb3BlbnRlbGVtZXRyeS1yZXNvdXJjZXMvc3JjL2RldGVjdG9ycy9wbGF0Zm9ybS9ub2RlL1NlcnZpY2VJbnN0YW5jZUlkRGV0ZWN0b3JTeW5jLnRz) | `57.14% <100.00%> (ø)` | | | [packages/opentelemetry-resources/src/semconv.ts](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5187?src=pr&el=tree&filepath=packages%2Fopentelemetry-resources%2Fsrc%2Fsemconv.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-cGFja2FnZXMvb3BlbnRlbGVtZXRyeS1yZXNvdXJjZXMvc3JjL3NlbWNvbnYudHM=) | `100.00% <100.00%> (ø)` | | | [...try-resources/src/detectors/BrowserDetectorSync.ts](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5187?src=pr&el=tree&filepath=packages%2Fopentelemetry-resources%2Fsrc%2Fdetectors%2FBrowserDetectorSync.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-cGFja2FnZXMvb3BlbnRlbGVtZXRyeS1yZXNvdXJjZXMvc3JjL2RldGVjdG9ycy9Ccm93c2VyRGV0ZWN0b3JTeW5jLnRz) | `52.94% <0.00%> (ø)` | | | [...lemetry-resources/src/detectors/EnvDetectorSync.ts](https://app.codecov.io/gh/open-telemetry/opentelemetry-js/pull/5187?src=pr&el=tree&filepath=packages%2Fopentelemetry-resources%2Fsrc%2Fdetectors%2FEnvDetectorSync.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-cGFja2FnZXMvb3BlbnRlbGVtZXRyeS1yZXNvdXJjZXMvc3JjL2RldGVjdG9ycy9FbnZEZXRlY3RvclN5bmMudHM=) | `94.11% <50.00%> (ø)` | |

🚨 Try these New Features: