search

open-telemetry / opentelemetry-log-collection

OpenTelemetry log collection library
https://opentelemetry.io
Apache License 2.0
92 stars 41 forks source link

tests(multiline): make tests more integration #486

Closed macdewee closed 2 years ago

macdewee commented 2 years ago

Fixes: open-telemetry/opentelemetry-collector-contrib#10277

It's rather small refactor in order to achieve the aim than writing new tests

codecov[bot] commented 2 years ago

Codecov Report

Merging #486 (64d64c9) into main (c912ec5) will decrease coverage by 0.0%. The diff coverage is n/a.

:exclamation: Current head 64d64c9 differs from pull request most recent head 92027f3. Consider uploading reports for the commit 92027f3 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##            main    open-telemetry/opentelemetry-log-collection#486     +/-   ##
=======================================
- Coverage   76.9%   76.9%   -0.1%     
=======================================
  Files         85      85             
  Lines       4153    4153             
=======================================
- Hits        3197    3195      -2     
- Misses       672     673      +1     
- Partials     284     285      +1
Impacted Files Coverage Δ
operator/input/tcp/tcp.go 78.4% <0.0%> (-1.6%) :arrow_down:
macdewee commented 2 years ago

I wasn't able to reproduce issue on macos. hope, the adjustment will work as expected

djaglowski commented 2 years ago

@Wolodija, thank you for your contribution here. Unfortunately, this repo is being deprecated, as the code has migrated to collector-contrib/pkg/stanza. I'd very much like to incorporate these changes if you're willing to reopen the PR against collector-contrib.