Bumping packages to fix build and security issues

jakub-racek-swi commented 2 months ago

Description: Bumping packages to fix build and security issues - this is accompanied by a PR to the build env, which must be merged first.

Link to tracking Issue:

Testing:

Documentation:

jakub-racek-swi commented 2 months ago

Hey @yonch, I was taking another look at the failing unit tests in my otel-network build.

I've made some progress with investigating the abseil failures, which is most likely related to some old issue that happens when asan is not applied to the entire build (https://github.com/abseil/abseil-cpp/issues/1524).

While investigating the 'render_test', I was trying to start the unit tests locally, but got wildly different test results.

The following tests FAILED:
          1 - render_test (Failed)
          9 - json_test (SEGFAULT)
         10 - fixed_hash_test (SEGFAULT)
         13 - log_modifiers_test (SEGFAULT)
         19 - bits_test (SEGFAULT)
         20 - counter_test (SEGFAULT)
         21 - counter_to_rate_test (SEGFAULT)
         25 - cgroup_handler_test (SEGFAULT)
         26 - kernel_symbols_test (Failed)

I am wondering how come the unit tests produce different results here in the github actions and when built locally on my machine. This is only with asan, however, as all tests do pass in the regular build.

I also wanted to ask how to handle debugging, since there is a --debug option in the build script. How do I set it up? Couldn't find any info in the docs sadly (though I could just be bad at navigating them :))

yonch commented 2 months ago

Hi @jakub-racek-swi !

I'm not sure regarding the ASAN failures. What CPU are you running on?

Let me check the debug builds. I remember we used to have a script to run under gdb..

yonch commented 2 months ago

So for debugging the kernel collector:

Here is the docker build clause for kernel-collector debug builds.
Setting the environment variable EBPF_NET_RUN_UNDER_GDB=gdb might get you what you want (from entrypoint.sh ).
If you're using the devbox scripts, the kernel collector's supports a --gdb flag

Hope this is what you're looking for..

yonch commented 1 month ago

Verified that this PR compiles with the new build image. 👍

My test run with ./build.sh --asan --debug test yields:

The following tests FAILED:
      1 - render_test (Failed)
     10 - fixed_hash_test (Failed)
     26 - kernel_symbols_test (Failed)

I didn't get the SEGFAULTs you got -- maybe you changed something since that earlier post?

Without ASAN tests seem to pass.

open-telemetry / opentelemetry-network

Bumping packages to fix build and security issues #275