Closed Starefossen closed 6 months ago
exporters:
prometheus:
endpoint: prometheus
The endpoint in the CR is not valid .
We should also fix the operator to avoid panic.
Hey ! I would love to help on this, I was having a look at those files :
I see the problem could come from the fact that if singlePortFromConfigEndpoint
is not able to parse the url then it returns nil
. What behaviour would you recommend in case the configuration is not correct ?
@dexter0195 To avoid panic, it makes sense to check at here if return of singlePortFromConfigEndpoint
is nil
, only append if it's not
prometheusPort := singlePortFromConfigEndpoint(o.logger, o.name, o.config)
if prometheusPort != nil {
ports = append(ports, *prometheusPort)
}
this has been closed by #2653 thanks for reporting!
Component(s)
No response
What happened?
Description
Operator exists with the following panic and enters CrashLoopBackoff after applying an
OpenTelemetryCollector
(see bellow) and stays crashing until theOpenTelemetryCollector
is deleted from the cluster. It is not possible to edit theOpenTelemetryCollector
due to the failing webhook.Steps to Reproduce
Apply the following OpenTelemetryCollector resource:
Expected Result
Operator should not panic and instead create the OpenTelemetry Collector.
Actual Result
Kubernetes Version
v1.28.3-gke.1286000
Operator version
0.93.0
Collector version
n/a
Environment information
Environment
Kubernetes: GKE
Log output
No response
Additional context
No response