Add support for k8s labels such as app.kubernetes.io/name

zeitlinger commented 3 months ago

Component(s)

auto-instrumentation

Is your feature request related to a problem? Please describe.

k8s labels such as app.kubernetes.io/name are recommended to set the app name and similar

See https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

this should be supported by the otel operator

Describe the solution you'd like

This mapping should work for the following labels:

app.kubernetes.io/name - service.name
app.kubernetes.io/instance - service.instance.id
app.kubernetes.io/version - service.version
app.kubernetes.io/part-of - service.namespace

And for the following annotations:

opentelemetry.io/resource.foo - foo (for any key) - note that the k8sattributes processor can also process those annotations, see https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34040

Describe alternatives you've considered

No response

Additional context

No response

jaronoff97 commented 2 months ago

@zeitlinger is this different from this issue? Wondering if i can merge these together.

zeitlinger commented 2 months ago

@zeitlinger is this different from this issue? Wondering if i can merge these together.

didn't know about it looks very similar

the prefix in my pr is opentelemetry.io/resource. instead of resource.opentelemetry.io/ - I don't have a strong preference
I also have support for common k8s variables (see description)
I think I've handled more edge cases in my pr

jaronoff97 commented 2 months ago

I think i prefer the resource.opentelemetry.io/, and agreed, I think your PR handles more. I'm going to close that issue and PR in favor of this one.

zeitlinger commented 2 months ago

resource.opentelemetry.io/

changed

jaronoff97 commented 2 months ago

@zeitlinger i added the discuss-at-sig label as it seems from Tyler's comment on the PR that there's some bigger picture stuff we need to figure out in order to not break users. We have a SIG meeting tomorrow (8/29) at noon EST where we will discuss this.

zeitlinger commented 2 months ago

@zeitlinger i added the discuss-at-sig label as it seems from Tyler's comment on the PR that there's some bigger picture stuff we need to figure out in order to not break users. We have a SIG meeting tomorrow (8/29) at noon EST where we will discuss this.

great - I'll join

open-telemetry / opentelemetry-operator