search

open-telemetry / opentelemetry-php

The OpenTelemetry PHP Library
https://opentelemetry.io/docs/instrumentation/php/
Apache License 2.0
751 stars 186 forks source link

Associating Spans with their TracerProvider #115

Closed bobstrecansky closed 4 years ago

bobstrecansky commented 4 years ago

In The Initial Resource SDK PR, @lalex added the Resource SDK to Tracer and TracerProvider. The spec states:

When used with distributed tracing, a resource can be associated with the TracerProvider when it is created. That association cannot be changed later. When associated with a TracerProvider, all Spans produced by any Tracer from the provider MUST be associated with this Resource.

This issue is to track the work of associating Spans with their TracerProvider.

bobstrecansky commented 4 years ago

@zsistla is working on is.

zsistla commented 4 years ago

I'll work on this :)

bobstrecansky commented 4 years ago

Closing this because we are going to eventually skip more towards a more recent alpha release.

zsistla commented 4 years ago

Hi Bob, I think this was erroneously closed when the alpha 0.2s were closed last week.

See PR: https://github.com/open-telemetry/opentelemetry-php/pull/215

status should be pending review.

bobstrecansky commented 4 years ago

Sorry Amber. I'll merge that tomorrow if I don't hear any gripes from the other maintainers and I'll close this at that time.