piotrantosik
commented
1 year ago I found the cause of the problem. My span exporter looks like this:
use Symfony\Component\HttpClient\HttpClient;
use Symfony\Component\HttpClient\Psr18Client;
$httpClient = new Psr18Client(
HttpClient::create(
defaultOptions: [
'headers' => [
],
'max_duration' => 1,
]
)
);
$resource = ResourceInfoFactory::defaultResource();
$spanExporter = (new SpanExporterFactory(new PsrTransportFactory(
client: $httpClient, requestFactory: $httpClient, streamFactory: $httpClient
)))->create();
$tracerProvider = TracerProvider::builder()
->addSpanProcessor(
(new BatchSpanProcessorBuilder($spanExporter))->build()
)
->setResource($resource)
->setSampler(new ParentBased(new AlwaysOnSampler()))
->build();
Sdk::builder()
->setTracerProvider($tracerProvider)
->setPropagator(TraceContextPropagator::getInstance())
->setAutoShutdown(true)
->buildAndRegisterGlobal();I also have a hook for this HttpClient (simplified):
hook(
HttpClient::class,
'request',
pre: static function (
HttpClientInterface $client,
array $params,
string $class,
string $function,
?string $filename,
?int $lineno,
) use ($instrumentation): array {
//code
},
post: static function (
HttpClientInterface $client,
array $params,
?ResponseInterface $response,
?\Throwable $exception,
): void {
//code
},
);And sigterm occurs if my otel collector returns other than 200 status code - then HttpClient throw an exception that broke php.
brettmc
pdelewski
bobstrecansky
Hi, During production rollout I have an issue with sigserv in php-fpm. I'm not good in low-level PHP but with debugging I found a problem with
OBJ_RELEASEfunction. Moving it to if condition solves my problem, commit:https://github.com/piotrantosik/opentelemetry-php-instrumentation/commit/0f449da5f5fec976be67b9ae7dfbabfe00d15063
I test with my changes (installing extension via
docker-php-extension-installer) and don't observe sigserv anymore.WARNING: [pool www] child 12 exited on signal 11 (SIGSEGV - core dumped) after 0.871070 seconds from startGDB trace (recompiled PHP with
--enable-debugflag, base docker image:8.0.22-fpm-alpine:3.16, but without Blackfire - i have some problems with debug flag & Blackfire):Trace without php debug flag: