codecov[bot]
commented
2 months ago Codecov Report
Attention: Patch coverage is 84.61538% with 12 lines in your changes are missing coverage. Please review.
Project coverage is 74.02%. Comparing base (
100e593) to head (c04ce0b).
implement the events api + sdk per spec v1.32:
todo: the spec is a little unclear on exactly how an EventLoggerProvider should access the Logger that it uses. Since the only way a Logger should be obtained is through a LoggerProvider (at least, that's true for other signals, but not expressly forbidden by the logs bridge API), I've gone with an EventLoggerProvider containing a LoggerProvider, from which it gets its logger.
The event logger API suggests that the above is correct ("EventLoggers can be accessed with a EventLoggerProvider"), however the event logger SDK says that "The SDK MAY be implemented on top of the Logs Bridge API".