open-telemetry / opentelemetry-php

The OpenTelemetry PHP Library
https://opentelemetry.io/docs/instrumentation/php/
Apache License 2.0
750 stars 186 forks source link

[Feature Request] Integrating Laravel with sqlcommenter #1346

Open moeyashi opened 4 months ago

moeyashi commented 4 months ago

Before opening a feature request against this repo, consider whether the feature should/could be implemented in the other OpenTelemetry client libraries. If so, please open an issue in opentelemetry-specification first.

This feature is implemented in python, django. And in the past there was a library for Laravel. https://github.com/open-telemetry/opentelemetry-sqlcommenter/blob/main/docs/python/django/README.md/#installation https://github.com/google/sqlcommenter/tree/master/php/sqlcommenter-php/packages/sqlcommenter-laravel

Is your feature request related to a problem?

It would be useful to add comments to the SQL. https://github.com/open-telemetry/opentelemetry-php/issues/1345

Describe the solution you'd like

Integrating Laravel with sqlcommenter.

Describe alternatives you've considered

I'm currently forking and using the google repository. https://github.com/moeyashi/sqlcommenter/tree/update-opentelemetry

Additional context

It's probably not something we'll implement right away.

I think we'll align our approach with other languages ​​through discussions on https://github.com/open-telemetry/opentelemetry-specification/issues/3560 and https://github.com/open-telemetry/opentelemetry-sqlcommenter/issues/5.

brettmc commented 4 months ago

@moeyashi are you planning to work on this? I can assign it to you. Otherwise, I'll add a help-wanted label.

moeyashi commented 4 months ago

@brettmc I don't have time to work on this for a several months so please label it.